Install Node.js and mystmd for GHA #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troyraen
added
infrastructure
bsipocz
reviewed
Nov 1, 2025
Member
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
I have a better way to do this (it's a one liner change), just didn't get around to open a PR yet.
(Also there is one for the failing build issue reporting, which may be cleaner than what's suggested here).
Contributor
Author
|
Ok, I'll close this and open an issue. Nothing will publish to the website until it's done. |
Member
|
Btw, this is the case where we may want to not delete a branch if it was on a fork but otoh such branches should not remain in the main repo (there should only the live and deployed remain in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think our GHA Publish HTML job is going to fail due to #162 (comment) until we install mystmd. This is my attempt.
I'm also attempting to add a step to the Publish HTML job that will open an issue if it fails or comment on an existing issue if one exists from a previous try. We've had failures of this job both here and in fornax-demo-notebooks that we haven't noticed right away, so this would help. Related to #127 but not added to the tests job yet.
I'm saying "attempt" because I don't have much experience managing workflows, so might be doing weird things. Definitely needs a close review before merging.